Daily Refactor #4: Extract Method in the BulkTimeEntriesHelper – options generator

# bulk_time_entries_helper.rb
  def grouped_options_for_issues(issues)
    open_issues = []
    closed_issues = []
    issues.each do |issue|
      if issue.closed?
        closed_issues << issue
      else
        open_issues << issue
      end
    end
 
    html = ''
    unless open_issues.empty?
      html << ""
      html << options_from_collection_for_select(open_issues, :id, :to_s)
      html << ""
    end
 
    unless closed_issues.empty?
      html << ""
      html << options_from_collection_for_select(closed_issues, :id, :to_s)
      html << ""
    end
    html
  end

# bulk_time_entries_helper.rb
  def grouped_options_for_issues(issues)
    open_issues = []
    closed_issues = []
    issues.each do |issue|
      if issue.closed?
        closed_issues << issue
      else
        open_issues << issue
      end
    end
 
    html = ''
    unless open_issues.empty?
      html << labeled_option_group_from_collection_for_select(:label_open_issues, open_issues)
    end
 
    unless closed_issues.empty?
      html << labeled_option_group_from_collection_for_select(:label_closed_issues, closed_issues)
    end
    html
  end
 
  def labeled_option_group_from_collection_for_select(label, collection)
    html = ""
    html << options_from_collection_for_select(collection, :id, :to_s)
    html << ""
    html
  end