Daily Refactor #14: Extract method to before_filter in ReportsController

The Refactoring

I started on a larger refactoring of the issue_report_details method today but found a potential security bug so I threw it away. It’s better to be secure than refactored :)

So instead, I performed a common Rails refactoring for removing duplicate code: extracting some code to a before filter.

Before

1
2
3
4
5
6
7
8
9
10
11
12
13

# app/controllers/reports_controller.rb
class ReportsController  'position')
 
    # ...
  end  
 
  def issue_report_details
    @statuses = IssueStatus.find(:all, :order => 'position')
 
    # ...
  end
 
end

After

1
2
3
4

# app/controllers/reports_controller.rb
class ReportsController  'position')
  end
end

Review

This is a good refactoring when your controller actions need some data but that data isn’t their core responsibility. For example the find_project and authorize before filters in Redmine will find the current project, user, and check that the permissions allow access. These don’t have anything to do with the actions, but they are still required.

Reference commit